Retain procedure appears to crash or get canceled when it fails to delete a piece #6482
Assignees
Labels
Bug
Something isn't working
Comments
|
Change storagenode/retain: don't quit on error mentions this issue. |
|
This issue has been mentioned on Storj Community Forum (official). There might be relevant details there: https://forum.storj.io/t/us1-storj-io-disk-average-30-lower-than-actual-disk-usage/24197/18 |
storjBuildBot
pushed a commit
that referenced
this issue
Nov 6, 2023
It has been noted in the forum that, during a Retain operation, when a piece can't be deleted, the process never completes. The error is written to the log, but the completion line "Moved pieces to trash during retain" never is. This `return` line is the reason. We should instead continue the loop. Change-Id: I0f51d34aba0e81ad60a75802069b42dc135ad907 Refs: #6482
|
closing this issue because the fix has been deployed to production. @thepaul @shaupt131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we are running a Retain operation, and we fail to delete a piece, we should continue with deleting the rest of the pieces, rather than crashing or quitting.
See, in particular, https://forum.storj.io/t/us1-storj-io-disk-average-30-lower-than-actual-disk-usage/24197/16
The text was updated successfully, but these errors were encountered: