Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop sending delete requests to Storage Nodes from the satellite #5888

Closed
iglesiasbrandon opened this issue May 17, 2023 · 2 comments
Closed

Stop sending delete requests to Storage Nodes from the satellite #5888

iglesiasbrandon opened this issue May 17, 2023 · 2 comments
Assignees
@mniewrzal
Milestone
Delete/ Server Si...

Comments

@iglesiasbrandon
Copy link
Contributor

Description:

As a part of the Delete/ Server Side Copy Refactor, we must stop sending delete requests from the satellite to the storage nodes.

This means when a customer performs a delete, the satellite will NOT send any requests to the storage nodes it will only delete that object/segment(s) in the database and then respond to the customer.

Acceptance Criteria:

  • The Satellite no longer sends delete requests to the Storage nodes
  • The Satellite deletes objects/ segments from the database when it receives a request from an uplink
    • We currently do this already
@storj-gerrit
Copy link

storj-gerrit bot commented May 26, 2023

Change satellite/metainfo: stop sending delete requests to SN mentions this issue.

@mniewrzal mniewrzal self-assigned this May 30, 2023
storjBuildBot pushed a commit that referenced this issue Jun 14, 2023
@mniewrzal
satellite/metainfo: stop sending delete requests to SN
6c08d50 
We decided that we will stop sending explicit delete requests to nodes
and we will cleanup deleted with GC instead.

#5888

Change-Id: I65a308cca6fb17e97e3ba85eb3212584c96a32cd
@shaupt131 shaupt131 added the Needs Estimation Issue still needs story pointing label Jun 20, 2023
@mniewrzal mniewrzal removed the Needs Estimation Issue still needs story pointing label Jun 20, 2023
@storjrobot
Copy link

This issue has been mentioned on Storj Community Forum (official). There might be relevant details there:

https://forum.storj.io/t/release-preparation-v1-82/23036/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mniewrzal mniewrzal

Labels
None yet
Projects
Object Versioning
Status: Done/Deployed
Team Satellite
Status: Done/Deployed
Milestone
Delete/ Server Side Copy Refactor
Development

No branches or pull requests
4 participants
@iglesiasbrandon @mniewrzal @storjrobot @shaupt131