Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satellite signup: Update activation flow #6428

Closed
mobyvb opened this issue Oct 18, 2023 · 5 comments
Closed

Satellite signup: Update activation flow #6428

mobyvb opened this issue Oct 18, 2023 · 5 comments
Assignees

Comments

@mobyvb
Copy link
Member

mobyvb commented Oct 18, 2023

Implement a new email verification method that makes use of a 6-digit emailed code rather than an activation link.

  • after signup, the user is directed to a page requesting to enter a 6-digit code
  • the user receives an email containing the code, which can be copy-pasted into the UI to activate the email
  • the activation email does not contain a link that can be clicked

Because this feature makes significant changes to common workflows, we should implement it with a feature flag, so that we can easily switch between link-based email verification and one-time-code-based email verification.

AC:

  • backend:
    • add a new type of email for verifying email that contains a code to be inputted into the UI, and no activation link
    • when a new account is created, store a random 6-digit code associated with that user in the DB, and send an email with that code
  • frontend:
    • implement the verification code in Vuetify (this is already a part of existing Vuetify mockups)
    • implement the verification code in the production app (can be templated off of the Vuetify version)
  • misc:
    • add a feature flag that allows us to use either link-based email verification, or code-based email verification. If using link-based email verification, it should behave the same as before
    • make sure it is possible to create an active, verified account in test setups (e.g. storj-up, storj-sim) where emails cannot be easily accessed
@mobyvb mobyvb added Needs Estimation Issue still needs story pointing and removed Needs Estimation Issue still needs story pointing labels Oct 18, 2023
@mobyvb mobyvb changed the title Investigation: activation improvements Satellite signup: Update activation flow Nov 7, 2023
@mobyvb mobyvb added the Needs Estimation Issue still needs story pointing label Nov 7, 2023
@wilfred-asomanii wilfred-asomanii self-assigned this Nov 13, 2023
@wilfred-asomanii wilfred-asomanii removed the Needs Estimation Issue still needs story pointing label Nov 13, 2023
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 14, 2023

Change satellite/db: add activation_code column mentions this issue.

@storj-gerrit
Copy link

storj-gerrit bot commented Nov 14, 2023

Change satellite/{console,web}: add activation code config flag mentions this issue.

@storj-gerrit
Copy link

storj-gerrit bot commented Nov 15, 2023

Change satellite/{console,emails}: add activation code email mentions this issue.

@storj-gerrit
Copy link

storj-gerrit bot commented Nov 15, 2023

Change satellite/console: implement account activation with code mentions this issue.

@storj-gerrit
Copy link

storj-gerrit bot commented Nov 16, 2023

Change web/satellite: implement account activation with code mentions this issue.

storjBuildBot pushed a commit that referenced this issue Nov 22, 2023
This change adds a new column to the user table, which will hold a
random code for account activation. And another to hold the signup
request ID as another layer of verification.

Issue: #6428

Change-Id: Icd46cb5d8fc76102264d599aca27686cd8b2e84e
storjBuildBot pushed a commit that referenced this issue Nov 22, 2023
This change adds a config flag for whether signup activation code
should be used.

Issue: #6428

Change-Id: I2b2b1e76f6013eab6438aefba848af0a4bd62544
storjBuildBot pushed a commit that referenced this issue Nov 22, 2023
This change adds an email template for sending activation codes.

Issue: #6428

Change-Id: Ief56a2e32ac0a335561572b9573215da24d9146b
andriikotko pushed a commit that referenced this issue Nov 28, 2023
This change adds a config flag for whether signup activation code
should be used.

Issue: #6428

Change-Id: I2b2b1e76f6013eab6438aefba848af0a4bd62544
andriikotko pushed a commit that referenced this issue Nov 28, 2023
This change adds a config flag for whether signup activation code
should be used.

Issue: #6428

Change-Id: I2b2b1e76f6013eab6438aefba848af0a4bd62544
storjBuildBot pushed a commit that referenced this issue Nov 29, 2023
This change implements account activation using OTP code. Based on
whether this activation method is activated, signup will generate a
6-digit code and send it via email. A new endpoint is added to validate
this code and activate the user's account and log them in.

Issue: #6428

Change-Id: Ia78bb123258021bce78ab9e98dce2c900328057a
storjBuildBot pushed a commit that referenced this issue Nov 29, 2023
This change implements account activation using OTP code. Based on
whether this activation method is activated, signup will require
    the user to fill the activation code to activate their account.

Issue: #6428

Change-Id: Ifdd3e34ddb8ab299dd24b183f9c484613b2e8888
@mobyvb mobyvb closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants