Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storagenode] Ability to turn off the storagenode version checker chore #6486

Closed
shaupt131 opened this issue Nov 7, 2023 · 5 comments
Closed
Assignees

Comments

@shaupt131
Copy link

shaupt131 commented Nov 7, 2023

Docker nodes contain a storagenode-updater that checks the storagenode version and automatically updates it. The storagenode also has a version checker chore that checks if the node is up to date and notifies on the dashboard's notification center. So for docker nodes, both the updater and storagenode runs a version checker chore, and you will never receive a notification about an outdated node binary if ypu're running a docker node because the updater will always update the node before the node's version checker will find out that the software needs update.

Acceptance criteria:

  • Add a config flag that allows to disable the version checker chore on the storagenode
  • Add an environment variable to the docker container which by default, disables the version checker chore

Value

  • this will reduce the amount of errors on the storage node if the checker fails
  • This will allow us to run storage nodes in an air-gapped environment so that we can disable to checker that reaches out to external services (which fails in this senario)
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 20, 2023

Change storagenode: add config flag to allow running version checker once mentions this issue.

@iglesiasbrandon
Copy link
Contributor

i dont understand the value of being able to disable to version checker chore on the storage node. can you please elaborate? @profclems

If the updater fails then you would receive an update when the version checker runs

storjBuildBot pushed a commit that referenced this issue Feb 7, 2024
This gives options to either disable the version checker in spc air-gapped
environments or set it to run once (especially for docker nodes that have
the updater binary already running periodically to check for new versions).

It is set to run periodically by default.

Issue: #6486
Change-Id: I40fa392309b9a36cd589e839298e2351d6814d9e
@littleskunk
Copy link
Member

This will allow us to run storage nodes in an air-gapped environment so that we can disable to checker that reaches out to external services (which fails in this senario)

I also don't get it. If version control is unreachable we end up with a docker contain with no storage node binary in it. Currently the storage node binary has to be downloaded from github otherwise the docker container doesn't work. Disabling the version doesn't make the docker container work.

@profclems profclems changed the title [storagenode] Ability to turn off the storagenode version checker chore on docker nodes [storagenode] Ability to turn off the storagenode version checker chore Feb 13, 2024
@profclems
Copy link
Member

@littleskunk Disabling it on the storagenode binary isn't the same as disabling it on the updater. And this is entirely different from the docker container directly downloading the binary because it does not depend on this flag. It will still download the binaries on start.

Also for air-gapped nodes, we have https://github.com/storj/storj-private/issues/382 to include a storagenode binary to the docker image.

@iglesiasbrandon
Copy link
Contributor

moving to deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done/Deployed
Development

No branches or pull requests

4 participants