Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetObject/DownloadObject metainfo versioned requests should return method not allowed on delete marker #6522

Closed
mniewrzal opened this issue Nov 20, 2023 · 2 comments
Closed

GetObject/DownloadObject metainfo versioned requests should return method not allowed on delete marker #6522

mniewrzal opened this issue Nov 20, 2023 · 2 comments
Assignees
@mniewrzal
Milestone
Object Versioning...

Comments

@mniewrzal
Copy link
Contributor

mniewrzal commented Nov 20, 2023 •
edited

S3 documentation (GetObject/HeadObject) is saying that if we will specify version and requested version will be delete marker method not allowed error will be returned.

If the specified version is a delete marker, the response returns a 405 (Method Not Allowed) error and the Last-Modified: timestamp response header.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html

We need to have the same logic on satellite side.

Acceptance Criteria:

  • metainfo requests GetObject/DownloadObject should return method not allowed if version is specified and object under this version is a delete marker
  • libuplink private methods for GetObject/DownloadObject should also expose this error
@mniewrzal mniewrzal added this to the Object Versioning Support milestone Nov 20, 2023
@mniewrzal mniewrzal self-assigned this Nov 20, 2023
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 20, 2023

Change rpc/rpcstatus: new MethodNotAllowed status mentions this issue.

@storj-gerrit
Copy link

storj-gerrit bot commented Nov 20, 2023

Change satellite/metainfo: (Get|Download)Object returns MethodNotAllowed on delete marker mentions this issue.

storjBuildBot pushed a commit to storj/common that referenced this issue Nov 21, 2023
@mniewrzal
rpc/rpcstatus: new MethodNotAllowed status
30983e2 
We are introducing new status code for metainfo usage.

storj/storj#6522

Change-Id: I35c306ecaa4b3f7c7b934247c84d199951621175
storjBuildBot pushed a commit that referenced this issue Nov 21, 2023
@mniewrzal
satellite/metainfo: (Get|Download)Object returns MethodNotAllowed on …
51ba901 
…delete marker

For S3 compatibility we should not allow returning pure delete
marker object. If metabase returns delete marker metainfo will
return MethodNotAllowed rpc status.

#6522

Change-Id: I89804b2bd22da0e5beec8f106e74b74733e19a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mniewrzal mniewrzal

Labels
None yet
Projects
Object Versioning
Status: Done/Deployed
Team Satellite
Status: Done/Deployed
Milestone
Object Versioning Support
Development

No branches or pull requests
2 participants
@mniewrzal @shaupt131