Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vuetify: Connect "add coupon" behavior to existing feature flag #6547

Closed
Tracked by #6535
mobyvb opened this issue Nov 27, 2023 · 1 comment
Closed
Tracked by #6535

Vuetify: Connect "add coupon" behavior to existing feature flag #6547

mobyvb opened this issue Nov 27, 2023 · 1 comment
Assignees
@VitaliiShpital
Labels
Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements

Comments

@mobyvb
Copy link
Member

mobyvb commented Nov 27, 2023 •
edited

There is a feature flag, console.coupon-code-billing-ui-enabled, which allows us to enable/disable the user's ability to enter a coupon code in the satellite UI. It is implemented properly in production, but not Vuetify.

The button in the provided screenshot, on the Vuetify billing overview tab, does not disappear when setting console.coupon-code-billing-ui-enabled=false.

Image

AC:

  • user cannot add a coupon in the vuetify app when the above mentioned feature is disabled
@mobyvb mobyvb mentioned this issue Nov 27, 2023
Closed
@mobyvb mobyvb added Needs Estimation Issue still needs story pointing Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements and removed Needs Estimation Issue still needs story pointing labels Nov 27, 2023
@VitaliiShpital VitaliiShpital self-assigned this Nov 30, 2023
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 30, 2023

Change web/satellite/vuetify-poc: hide 'Add coupon' button when coupon features are disabled mentions this issue.

storjBuildBot pushed a commit that referenced this issue Dec 4, 2023
@VitaliiShpital
web/satellite/vuetify-poc: hide 'Add coupon' button when coupon featu…
7b3770e 
…res are disabled

Hide button if feature flag is set to false.

Issue:
#6547

Change-Id: I0e13bacfe6a8651ebc573abc3f23a749821d63a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VitaliiShpital VitaliiShpital

Labels
Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mobyvb @VitaliiShpital