Support changing RS optimal value (currently 80 everywhere) for existing segments upon repair #6594
Assignees
Comments
|
Change satellite/repair/checker: change override flag format mentions this issue. |
|
Change satellite/repair/repairer: allow overriding optimal shares while repair mentions this issue. |
storjBuildBot
pushed a commit
that referenced
this issue
Mar 21, 2024
This is initial change to support overriding optimal shares while repairing. This change simplifies flag format to specify override from "29/80/110-52" to "29-52". We will use the same format later to specify target repair value. Change is backward compatible. #6594 Change-Id: I7d057745e6f7292bf8d292dd7d0fc9c6eaf186a5
storjBuildBot
pushed a commit
that referenced
this issue
Mar 25, 2024
This change is adding new repair flag "checker.repair-target-overrides". This flag defines override for segment RS optimal shares value. We can use it to change optimal shares for existing segments while repair. We want to do that for all segments from before introducing new RS schema for new uploads (optimal shares = 65). #6594 Change-Id: I9462ddbb5912838edc17c45c67fc6736f5ed77b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our expansion factor is too high. While we don't know how much it is too high, it will eventually be desired to reduce the 80 number for the 29 out of 80.
If we change metainfo.rs in the Satellite config, that only changes the RS settings for new segments. When repair operates on an existing segment, it uses the parameters from the segment in the database.
If a segment falls below the repair threshold, we may want to only repair it up to a new max optimum threshold, which in the future is likely less than 80. (a 2.5x expansion factor would be 72, for example)
Make it so that the optimal and total RS values for new and existing segments are override-able, like the existing repair threshold.
The text was updated successfully, but these errors were encountered: