Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: flaky /v2/signup redirect behavior in QA #6676

Closed
mobyvb opened this issue Jan 8, 2024 · 2 comments
Closed

V2: flaky /v2/signup redirect behavior in QA #6676

mobyvb opened this issue Jan 8, 2024 · 2 comments
Assignees

Comments

@mobyvb
Copy link
Member

mobyvb commented Jan 8, 2024

console.new-signup-flow-enabled is true on the QA satellite.

Visiting https://satellite.qa.storj.io/v2/signup sometimes properly loads the v2 signup page. In this situation, you can look at the api/v0/config request and notice the "newSignupFlowEnabled": true:

Image

If you continue to refresh, eventually it will redirect to https://satellite.qa.storj.io/signup, and it may get stuck there for a while. It is flaky. In this case, the second to last config request will look like this:

Image

The redirect happens at the beginning "before mount" hook in vuetify-poc/src/views/Signup.vue:

onBeforeMount(async () => {
    if (!configStore.state.config.newSignupFlowEnabled) {
        location.replace(RouteConfig.Register.path);
        return;
    }

Perhaps this is a race condition - if this "before mount" executes before the config request has completed, newSignupFlowEnabled will be false, regardless of the config on the satellite API pod.

AC:

  • redirect for newSignupFlowEnabled does not happen until after config fetch succeeds
@mobyvb mobyvb added Needs Estimation Issue still needs story pointing Needs Grooming and removed Needs Grooming labels Jan 8, 2024
@storj-gerrit
Copy link

storj-gerrit bot commented Jan 9, 2024

Change web/satellite/vuetify-poc: fix flaky signup redirect mentions this issue.

@wilfred-asomanii wilfred-asomanii self-assigned this Jan 9, 2024
@mobyvb mobyvb removed the Needs Estimation Issue still needs story pointing label Jan 9, 2024
storjBuildBot pushed a commit that referenced this issue Jan 11, 2024
redirect

This change fixes an issue where the v2 signup will eroneously redirect
to the v1 signup because satellite config might have not been fetched
at that point.

Issue: #6676

Change-Id: I22f521fb67e3fa75748bc44d48d81fbdafd1de62
@wilfred-asomanii
Copy link
Contributor

v1.96.6 20d389b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants