Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: show loading instead of error message when unauthenticated #6699

Closed
Tracked by #6687
mobyvb opened this issue Jan 17, 2024 · 2 comments
Closed
Tracked by #6687

V2: show loading instead of error message when unauthenticated #6699

mobyvb opened this issue Jan 17, 2024 · 2 comments
Assignees
Labels
Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements

Comments

@mobyvb
Copy link
Member

mobyvb commented Jan 17, 2024

In V1, if navigating to the app while unauthenticated, the visitor sees a loading screen before redirecting to login:
https://us1.storj.io/project-dashboard
But in V2, navigating to the app while unauthenticated, the visitor sees the project dashboard and an error message before redirecting to login:
https://us1.storj.io/v2/projects

AC:

  • loading screen before redirect is shown on V2, when user is unauthenticated
@mobyvb mobyvb added Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements Needs Estimation Issue still needs story pointing labels Jan 17, 2024
@mobyvb mobyvb assigned mobyvb and unassigned mobyvb Jan 17, 2024
@wilfred-asomanii wilfred-asomanii self-assigned this Jan 18, 2024
@storj-gerrit
Copy link

storj-gerrit bot commented Jan 18, 2024

Change web/satellite/v2: fix unauthenticated navigation mentions this issue.

storjBuildBot pushed a commit that referenced this issue Jan 18, 2024
This change fixes an issue where navigating directly to a page when
unauthenticated will show the page for a while before navigating to the
login page, by introducing a full screen loader as seen in the V1 app.
It also moves certain page setup calls (user, projects etc.) to App.vue
so as not to replicate the login-redirect logic in more places. This
also helps avoid calling for setup data that have already been fetched.
Finally, navigation directly to the authentication pages is prevented.

Issue: #6699

Change-Id: I3b5f8570c7d430f2afc5b0366f0e32852e4d1ae0
andriikotko pushed a commit that referenced this issue Jan 18, 2024
This change fixes an issue where navigating directly to a page when
unauthenticated will show the page for a while before navigating to the
login page, by introducing a full screen loader as seen in the V1 app.
It also moves certain page setup calls (user, projects etc.) to App.vue
so as not to replicate the login-redirect logic in more places. This
also helps avoid calling for setup data that have already been fetched.
Finally, navigation directly to the authentication pages is prevented.

Issue: #6699

Change-Id: I3b5f8570c7d430f2afc5b0366f0e32852e4d1ae0
andriikotko pushed a commit that referenced this issue Jan 18, 2024
This change fixes an issue where navigating directly to a page when
unauthenticated will show the page for a while before navigating to the
login page, by introducing a full screen loader as seen in the V1 app.
It also moves certain page setup calls (user, projects etc.) to App.vue
so as not to replicate the login-redirect logic in more places. This
also helps avoid calling for setup data that have already been fetched.
Finally, navigation directly to the authentication pages is prevented.

Issue: #6699

Change-Id: I3b5f8570c7d430f2afc5b0366f0e32852e4d1ae0
@mobyvb mobyvb removed the Needs Estimation Issue still needs story pointing label Jan 18, 2024
@wilfred-asomanii
Copy link
Contributor

v1.97.2 7534277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vuetify CI continuous improvement of Vueitfy - fix bugs and ehnhancements
Projects
None yet
Development

No branches or pull requests

2 participants