New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagenode: after bump from v1.96.6 to v1.97.2 is crashing on Windows #6818

Closed

egonelbre opened this issue Feb 29, 2024 · 3 comments

Assignees

Labels

Bug SNO

Member

egonelbre commented Feb 29, 2024 •

edited

We got several notices that storagenodes started failing on Windows after a bump from v1.96.6 to v1.97.2.

Sidenote, it technically might not be exactly related to Windows; however, we haven't gotten any reports from non-Windows, yet.

egonelbre added Bug SNO labels

egonelbre self-assigned this

storj-gerrit bot commented Feb 29, 2024

Change private/date: fix PeriodToTime for invalid periods mentions this issue.

storj-gerrit bot commented Feb 29, 2024

Change cmd/storagenode: add more logging mentions this issue.

storjBuildBot pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

6b626bc

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

storjBuildBot pushed a commit that referenced this issue


          cmd/storagenode: add more logging

b308386

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

storj-gerrit bot commented Mar 7, 2024

Change storagenode/blobstore: fix disk space on windows mentions this issue.

profclems mentioned this issue

Windows node shows total amount of free space instead of total amount of disk space #6834

Open

storjBuildBot pushed a commit that referenced this issue


          storagenode/blobstore: fix disk space on windows

73998fc

So on windows nodes, the total disk space was showing
the total number of free bytes on the disk due to
this change d96c411.

According to the documentation for GetDiskFreeSpaceExW:

- 1st pointer = Directory name
- Second pointer = the total amount of free space available to the
  user associated with the calling thread
- 3rd pointer = total amount of space
- 4th pointer = total amount of free space

Ref: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexw

Could be the reason for nodes crushing on windows
#6818

Change-Id: I47081ed658caf26557f7da618b3be4aecb95cf1a

andriikotko pushed a commit that referenced this issue


          storagenode/blobstore: fix disk space on windows

3923a20

So on windows nodes, the total disk space was showing
the total number of free bytes on the disk due to
this change d96c411.

According to the documentation for GetDiskFreeSpaceExW:

- 1st pointer = Directory name
- Second pointer = the total amount of free space available to the
  user associated with the calling thread
- 3rd pointer = total amount of space
- 4th pointer = total amount of free space

Ref: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexw

Could be the reason for nodes crushing on windows
#6818

Change-Id: I47081ed658caf26557f7da618b3be4aecb95cf1a

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

e3d691f

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

5c3a734

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          storagenode/blobstore: fix disk space on windows

So on windows nodes, the total disk space was showing
the total number of free bytes on the disk due to
this change d96c411.

According to the documentation for GetDiskFreeSpaceExW:

- 1st pointer = Directory name
- Second pointer = the total amount of free space available to the
  user associated with the calling thread
- 3rd pointer = total amount of space
- 4th pointer = total amount of free space

Ref: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexw

Could be the reason for nodes crushing on windows
#6818

Change-Id: I47081ed658caf26557f7da618b3be4aecb95cf1a

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

02f7568

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

5e97ec7

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

c3491af

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

bd62ae3

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

cfa19a5

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

be87f62

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          storagenode/blobstore: fix disk space on windows

d60f2a8

So on windows nodes, the total disk space was showing
the total number of free bytes on the disk due to
this change d96c411.

According to the documentation for GetDiskFreeSpaceExW:

- 1st pointer = Directory name
- Second pointer = the total amount of free space available to the
  user associated with the calling thread
- 3rd pointer = total amount of space
- 4th pointer = total amount of free space

Ref: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexw

Could be the reason for nodes crushing on windows
#6818

Change-Id: I47081ed658caf26557f7da618b3be4aecb95cf1a

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

c7b60ff

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

45bf62c

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          private/date: fix PeriodToTime for invalid periods

320aa9b

Updates #6818

Change-Id: I626945636bac901700b900a5594473fa33c3f288

andriikotko pushed a commit that referenced this issue


          cmd/storagenode: add more logging

b8f452d

Updates #6818

Change-Id: I03465c9424a4a56c589037feff7e0b66d21809c1

andriikotko pushed a commit that referenced this issue


          storagenode/blobstore: fix disk space on windows

28d00b5

So on windows nodes, the total disk space was showing
the total number of free bytes on the disk due to
this change d96c411.

According to the documentation for GetDiskFreeSpaceExW:

- 1st pointer = Directory name
- Second pointer = the total amount of free space available to the
  user associated with the calling thread
- 3rd pointer = total amount of space
- 4th pointer = total amount of free space

Ref: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexw

Could be the reason for nodes crushing on windows
#6818

Change-Id: I47081ed658caf26557f7da618b3be4aecb95cf1a

egonelbre closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment