Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement storj.NodeURL in trusted satellites #2388

Merged
merged 27 commits into from Jul 3, 2019
Merged

Conversation

cam-a
Copy link
Contributor

@cam-a cam-a commented Jun 28, 2019

Implement storj.NodeURL and add address to trusted satellites

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cam-a cam-a added the WIP Work In Progress label Jun 28, 2019
@cam-a cam-a requested a review from aleitner as a code owner June 28, 2019 22:17
@cla-bot cla-bot bot added the cla-signed label Jun 28, 2019
@cam-a cam-a removed the WIP Work In Progress label Jul 2, 2019
@jenlij jenlij added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR Sprint Release Goal Sprint Release Goal labels Jul 3, 2019
Copy link
Contributor

@jenlij jenlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cam-a cam-a merged commit d499d16 into master Jul 3, 2019
@cam-a cam-a deleted the trusted-nodeURLs branch July 3, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR Sprint Release Goal Sprint Release Goal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants