Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellie/gc: enable garbage collection on the satellite #2765

Merged
merged 2 commits into from Aug 12, 2019

Conversation

littleskunk
Copy link
Member

What: Enable garbage collection on the satellite side. Don't enable it on the storage node.

Why: Garbage collection is working great on the satellite side. We don't see any performance impact. We can go ahead and enable it on all satellites. On the storage node side we can't because there is an annoying timeout issue.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@littleskunk littleskunk requested a review from a team August 12, 2019 18:14
@cla-bot cla-bot bot added the cla-signed label Aug 12, 2019
@ghost ghost requested review from thepaul and VinozzZ and removed request for a team August 12, 2019 18:14
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonelbre egonelbre changed the title enable garbage collection on the satellite satellie/gc: enable garbage collection on the satellite Aug 12, 2019
@littleskunk littleskunk added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Aug 12, 2019
@littleskunk littleskunk merged commit 3e41767 into master Aug 12, 2019
@littleskunk littleskunk deleted the jh/garbage-collection branch August 12, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants