storagenode/contact: create chore for nodes to ping satellites #2877
Conversation
|
Make sure to update storj-sim and testplanet |
ghost
requested review from
Barterio and
JessicaGreben
and removed request for
a team
cam-a
added
Request Code Review
cam-a
changed the title
| } | ||
|
|
||
| // PingStats contains information regarding who and when the node was last pinged | ||
| type PingStats struct { |
There was a problem hiding this comment.
why do we need to track when/who the node was last pinged?
There was a problem hiding this comment.
just for the node dashboard
There was a problem hiding this comment.
I believe the dashboard indicates the last time you were contacted to let you know you are still externally accessible
| func (stats *PingStats) WhenLastPinged() (when time.Time, who storj.NodeID, addr string) { | ||
| stats.mu.Lock() | ||
| defer stats.mu.Unlock() | ||
| return stats.lastPinged, stats.whoPingedNodeID, stats.whoPingedAddress |
There was a problem hiding this comment.
it looks like this method WhenLastPinged isn't currently being used anywhere. Is there a use case for this method to be used in the future? Im just thinking that if the node restarts for any reason, pingStats will get reset and these fields will be empty. Not sure if that will affect anything
There was a problem hiding this comment.
It will be used by the dashboard to get the last contacted time. I'm also using it in the test
| } | ||
| } | ||
|
|
||
| // Run the contact chore on a regular interval with jitter |
There was a problem hiding this comment.
not sure if we should expand on this comment a little bit and explain what is meant by jitter
What: Creates a chore for nodes to announce themselves to their trusted satellites. Runs on startup and every hour thereafter
Why: Kademlia Removal
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)