satellite/vouchers: deprecate voucher endpoint, return 'please upgrade' error #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kaloyan-raev and
rikysya
and removed request for
a team
littleskunk
previously approved these changes
Sep 4, 2019
satellite/vouchers/endpoint.go
Outdated
| expiration: expiration, | ||
| } | ||
| } | ||
| type Endpoint struct{} | ||
|
|
||
| // Request receives a voucher request and returns a voucher and an error |
There was a problem hiding this comment.
update comment, do we want to say that this is kept in for backwards compatibility?
satellite/vouchers/endpoint.go
Outdated
| type Config struct { | ||
| Expiration time.Duration `help:"length of time before a voucher expires" default:"720h0m0s"` | ||
| } | ||
|
|
||
| // Endpoint for issuing signed vouchers |
There was a problem hiding this comment.
could we update this comment and say this is deprecated
JessicaGreben
approved these changes
Sep 4, 2019
jenlij
reviewed
Sep 4, 2019
| Voucher: voucher, | ||
| Status: pb.VoucherResponse_ACCEPTED, | ||
| }, nil | ||
| return nil, errs.New("Vouchers endpoint is deprecated. Please upgrade your storage node to the latest version.") |
There was a problem hiding this comment.
will this cause any crashing downstream?
There was a problem hiding this comment.
It shouldn't. The old storage node voucher service just logs errors and continues running and I have a test for checking that the client receives the correct error message
jenlij
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Since we are removing kademlia, we no longer need vouchers. We have already removed the voucher request service on the storage node. This PR removes the logic inside the satellite vouchers endpoint and instead returns a custom error asking the storage node to upgrade to the latest version
Why: We have already removed the storage node voucher request service, but not all storage node operators will have updated to this version. If we remove the satellite vouchers endpoint entirely, those who have not upgraded will see errors and ask the community for help. Returning a custom error asking the storage node to upgrade should remedy the situation
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)