-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Bootstrap and Kademlia #2974
Conversation
29f69bb
to
e50ba69
Compare
5319413
to
e859a1d
Compare
85bbeb1
to
2aae5e7
Compare
satellite/overlay/service.go
Outdated
// If we get a Node without an ID (i.e. bootstrap node) | ||
// we don't want to add to the routing tbale | ||
// If we get a Node without an ID | ||
// we don't want to add to the cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
@@ -12,6 +12,7 @@ import "google/protobuf/timestamp.proto"; | |||
|
|||
package inspector; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change inspector packages as needed and overridde the lock file, since they are not part of the communication protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge PR, But looks good to me
85b2d13
to
1b3bfe9
Compare
What: Removes the boostrap node files and usages & deletes entire kademlia package
Why: Since we are replacing kademlia with a direct node to satellite discovery process, we no longer need any bootstrap nodes
Note: Don't fret about the 84 files changed. Most are deletions or mechanical changes.
Code Review Checklist (to be filled out by reviewer)