Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplink "import" command #2981

Merged
merged 7 commits into from
Sep 13, 2019
Merged

Uplink "import" command #2981

merged 7 commits into from
Sep 13, 2019

Conversation

azdagron
Copy link
Contributor

@azdagron azdagron commented Sep 9, 2019

What:

  • import command to import a scope from a file.
  • Added an --export-to flag to the share command to export a scope that can be imported
  • Added a way to mark a flag so that it is visible, yet does not persist in the configuration file (i.e. "flag" source)

Why:
Lights up previously added capability for uplink to utilize different scopes by allowing scopes to be exported and imported.

Please describe the tests:
None. There is no existing unit test infrastructure for the CLI commands. The commands were tested manually. Adding CLI unit-test infrastructure is outside the scope of this PR and can be addressed in a follow up PR.

Please describe the performance impact:
N/A

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@azdagron azdagron requested a review from a team September 9, 2019 14:52
@cla-bot cla-bot bot added the cla-signed label Sep 9, 2019
@ghost ghost requested review from jenlij and wthorp and removed request for a team September 9, 2019 14:52
@azdagron azdagron added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Sep 9, 2019
@azdagron azdagron requested a review from zeebo September 11, 2019 16:34
zeebo
zeebo previously approved these changes Sep 11, 2019
@azdagron azdagron merged commit f550ab5 into master Sep 13, 2019
@azdagron azdagron deleted the ah/uplink-import-cmd branch September 13, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants