cmd/uplink: fix progressbar data race #2987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a data race in the old version version of
cheggaaa/pb
, use a newer version. Also ensure that the bar has always been finished before we return.Based on issue reports and commit history, this should fix it, however since there isn't a good reproducer, it's not entirely clear whether it completely fixes it or not.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)