Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/uplink: fix progressbar data race #2987

Merged
merged 3 commits into from
Sep 10, 2019
Merged

cmd/uplink: fix progressbar data race #2987

merged 3 commits into from
Sep 10, 2019

Conversation

egonelbre
Copy link
Member

@egonelbre egonelbre commented Sep 10, 2019

There was a data race in the old version version of cheggaaa/pb, use a newer version. Also ensure that the bar has always been finished before we return.

Based on issue reports and commit history, this should fix it, however since there isn't a good reproducer, it's not entirely clear whether it completely fixes it or not.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2019
@egonelbre egonelbre marked this pull request as ready for review September 10, 2019 07:33
@egonelbre egonelbre requested a review from a team September 10, 2019 07:33
@ghost ghost requested review from cam-a and mniewrzal and removed request for a team September 10, 2019 07:33
@egonelbre egonelbre added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Sep 10, 2019
Copy link
Contributor

@mniewrzal mniewrzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does the new progress bar not need the specification of width and units?

@egonelbre
Copy link
Member Author

@stefanbenten when you use NewProxyReader it will automatically switch to bytes mode.

@egonelbre egonelbre merged commit 0d4fd6c into master Sep 10, 2019
@egonelbre egonelbre deleted the ee/progressbar branch September 10, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants