Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storagenode/storagenodedb: add new tables for graceful exit #3008

Merged
merged 5 commits into from
Sep 11, 2019

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Sep 11, 2019

What:

  • add satellites_exit_progress and satellites table into storagenodedb

Why:

These tables will be used to track graceful exit process on storage node
https://storjlabs.atlassian.net/browse/V3-2590?atlOrigin=eyJpIjoiZThjNzRiMzg1Y2RhNGJiOThjNzk1Y2NmYTJiNTRhNWQiLCJwIjoiaiJ9

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@VinozzZ VinozzZ requested a review from a team September 11, 2019 21:41
@cla-bot cla-bot bot added the cla-signed label Sep 11, 2019
@ghost ghost requested review from isaachess and jenlij and removed request for a team September 11, 2019 21:41
@VinozzZ VinozzZ added the Request Code Review Code review requested label Sep 11, 2019
isaachess
isaachess previously approved these changes Sep 11, 2019
Copy link
Contributor

@isaachess isaachess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@isaachess
Copy link
Contributor

Sorry about the conflicts here. We're all working in the same files!

status INTEGER NOT NULL,
PRIMARY KEY (node_id)
)`,
`CREATE TABLE satellites_exit_progress (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the blueprint called it satellites_exit_progress, but I think we should change to satellite_exit_progress

Can you update the blueprint in this PR with the status and table name changes. It would be good to track them together I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

@VinozzZ VinozzZ added the Reviewer Can Merge If all checks have passed, non-owner can merge PR label Sep 11, 2019
Copy link
Contributor

@isaachess isaachess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still looks good to me! 😸

@VinozzZ VinozzZ merged commit 9f2f152 into master Sep 11, 2019
@VinozzZ VinozzZ deleted the green/storagenode-gc-db branch September 11, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants