-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storagenode/storagenodedb: add new tables for graceful exit #3008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sorry about the conflicts here. We're all working in the same files! |
status INTEGER NOT NULL, | ||
PRIMARY KEY (node_id) | ||
)`, | ||
`CREATE TABLE satellites_exit_progress ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the blueprint called it satellites_exit_progress
, but I think we should change to satellite_exit_progress
Can you update the blueprint in this PR with the status
and table name changes. It would be good to track them together I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still looks good to me! 😸
What:
satellites_exit_progress
andsatellites
table into storagenodedbWhy:
These tables will be used to track graceful exit process on storage node
https://storjlabs.atlassian.net/browse/V3-2590?atlOrigin=eyJpIjoiZThjNzRiMzg1Y2RhNGJiOThjNzk1Y2NmYTJiNTRhNWQiLCJwIjoiaiJ9
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)