Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storj-sim: correct storagenode dashboard config #3010

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

littleskunk
Copy link
Member

What: Correct the storagnode dashboard config.

Why: Because web/console doesn't exist.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@littleskunk littleskunk added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Sep 11, 2019
@littleskunk littleskunk requested a review from a team September 11, 2019 21:49
@cla-bot cla-bot bot added the cla-signed label Sep 11, 2019
@ghost ghost requested review from JessicaGreben and mobyvb and removed request for a team September 11, 2019 21:50
@egonelbre egonelbre merged commit 1d8cd52 into master Sep 12, 2019
@egonelbre egonelbre deleted the jh/dashboard branch September 12, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants