Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplink/ecclient: Report success in debug level #3037

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Conversation

ifraixedes
Copy link
Member

What: Change a log message from INFO to DEBUG.

Why: packages shouldn't be chatty when the things go as expected unless the DEBUG log level is set.

Please describe the tests: N/A
Please describe the performance impact: N/A

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Packages shouldn't be chatty when the things go as expected unless the
DEBUG log level is set.
@ifraixedes ifraixedes added Enhancement New feature or request Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Sep 12, 2019
@ifraixedes ifraixedes requested a review from a team September 12, 2019 18:10
@ifraixedes ifraixedes self-assigned this Sep 12, 2019
@cla-bot cla-bot bot added the cla-signed label Sep 12, 2019
@ghost ghost requested review from ethanadams and simongui and removed request for a team September 12, 2019 18:10
@ifraixedes ifraixedes merged commit 8a48500 into master Sep 13, 2019
@ifraixedes ifraixedes deleted the if/log-info-to-debug branch September 13, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Enhancement New feature or request Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants