Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/blueprints: referral manager v1 #3038

Merged
merged 29 commits into from
Oct 7, 2019
Merged

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Sep 12, 2019

What:

design doc for referral manager v1

Why:

Due to business requirement changes, we need to pivot from the previous design.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2019
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
@VinozzZ VinozzZ added the Request Code Review Code review requested label Sep 13, 2019
@VinozzZ VinozzZ marked this pull request as ready for review September 13, 2019 18:03
@VinozzZ VinozzZ requested a review from a team September 13, 2019 18:03
@ghost ghost requested review from kaloyan-raev and thepaul and removed request for a team September 13, 2019 18:04
@ghost ghost removed their request for review September 13, 2019 18:04
@VinozzZ VinozzZ requested a review from mobyvb September 13, 2019 18:04
@mobyvb mobyvb force-pushed the green/referral-manager-blueprint branch from 433d6fd to 804ab95 Compare September 20, 2019 20:28
@VinozzZ VinozzZ requested a review from mobyvb October 1, 2019 13:48
@VinozzZ VinozzZ added the Reviewer Can Merge If all checks have passed, non-owner can merge PR label Oct 2, 2019
egonelbre
egonelbre previously approved these changes Oct 2, 2019
Copy link
Member

@egonelbre egonelbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
thepaul
thepaul previously approved these changes Oct 3, 2019
docs/blueprints/referral-manager-v1.md Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
docs/blueprints/referral-manager-v1.md Outdated Show resolved Hide resolved
jtolio
jtolio previously approved these changes Oct 3, 2019
Copy link
Member

@jtolio jtolio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! great work! i didn't review the pseudocode, but i definitely echo paul's sentiments about making sure to use transactions

@VinozzZ VinozzZ dismissed stale reviews from jtolio, thepaul, and egonelbre via 27c54e6 October 3, 2019 23:31
@VinozzZ VinozzZ merged commit d29946d into master Oct 7, 2019
@VinozzZ VinozzZ deleted the green/referral-manager-blueprint branch October 7, 2019 13:38
@VinozzZ VinozzZ mentioned this pull request Oct 15, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Doc Adding or updating a design document. Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants