-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/blueprints: referral manager v1 #3038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navillasa
reviewed
Sep 13, 2019
ghost
requested review from
kaloyan-raev and
thepaul
and removed request for
a team
September 13, 2019 18:04
VinozzZ
requested review from
brimstone,
egonelbre,
ethanadams,
jtolio and
a team
September 13, 2019 18:04
ghost
removed their request for review
September 13, 2019 18:04
ethanadams
reviewed
Sep 16, 2019
mobyvb
reviewed
Sep 17, 2019
…torj into green/referral-manager-blueprint
mobyvb
force-pushed
the
green/referral-manager-blueprint
branch
from
September 20, 2019 20:28
433d6fd
to
804ab95
Compare
VinozzZ
commented
Sep 21, 2019
VinozzZ
commented
Sep 21, 2019
VinozzZ
commented
Sep 21, 2019
VinozzZ
commented
Sep 21, 2019
VinozzZ
added
the
Reviewer Can Merge
If all checks have passed, non-owner can merge PR
label
Oct 2, 2019
egonelbre
previously approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
thepaul
previously approved these changes
Oct 3, 2019
jtolio
previously approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! great work! i didn't review the pseudocode, but i definitely echo paul's sentiments about making sure to use transactions
thepaul
approved these changes
Oct 6, 2019
egonelbre
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
Design Doc
Adding or updating a design document.
Request Code Review
Code review requested
Reviewer Can Merge
If all checks have passed, non-owner can merge PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
design doc for referral manager v1
Why:
Due to business requirement changes, we need to pivot from the previous design.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)