-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile: API updates #3155
mobile: API updates #3155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding correctly that the purpose for the struct wrappers around things like Scope
, APIKey
, etc. is to be able to alter method definitions? If so, since we're now defining the high-level API in java, can we push that logic into java and just use the libuplink structs directly in the gomobile code (admittedly, that may be out of scope for this PR)? It's a bit confusing to follow structs of the same name defined in libuplink and then again in the gomobile code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my previous comment/question, this looks good!
Purpose of |
@@ -146,7 +152,7 @@ func (project *Project) ListBuckets(cursor string, limit int) (*BucketList, erro | |||
scope := project.scope.child() | |||
opts := libuplink.BucketListOptions{ | |||
Cursor: cursor, | |||
Direction: storj.Forward, | |||
Direction: storj.After, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe let's change the cursor
name here, to make it clear that it defaults to after. e.g. after string
6682ef2
What: Changes for mobile API:
SkipPeerCAWhitelist
option in uplink configScope
typestorj.After
scope
insteadapikey
Why: we need update gomobile API to build Java API facade
Please describe the tests:
Please describe the performance impact: none
Code Review Checklist (to be filled out by reviewer)