Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: build libuplink aar #3165

Merged
merged 4 commits into from
Oct 4, 2019
Merged

mobile: build libuplink aar #3165

merged 4 commits into from
Oct 4, 2019

Conversation

mniewrzal
Copy link
Contributor

@mniewrzal mniewrzal commented Oct 3, 2019

What: Add building libuplink-android.aar to Makefile.

Why: We need to automate libuplink-android and this change is part of larger task.

Please describe the tests:

  • Test 1: none

Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@mniewrzal mniewrzal added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 3, 2019
@mniewrzal mniewrzal requested a review from a team October 3, 2019 09:49
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2019
@ghost ghost requested review from Barterio and isaachess and removed request for a team October 3, 2019 09:50
kaloyan-raev
kaloyan-raev previously approved these changes Oct 3, 2019
.gitignore Outdated
@@ -34,3 +34,5 @@ debug
resource.syso

*.resource.go

vendor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the building is happening in a temporary directory, do we need to ignore vendor dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, maybe its a good idea to do everything in tmp dir.

Done.

@mniewrzal mniewrzal merged commit 794254b into master Oct 4, 2019
@mniewrzal mniewrzal deleted the mn/build-libuplink-android branch October 4, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants