-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile: build libuplink aar #3165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniewrzal
added
Request Code Review
Code review requested
Reviewer Can Merge
If all checks have passed, non-owner can merge PR
labels
Oct 3, 2019
ghost
requested review from
Barterio and
isaachess
and removed request for
a team
October 3, 2019 09:50
kaloyan-raev
previously approved these changes
Oct 3, 2019
egonelbre
reviewed
Oct 3, 2019
.gitignore
Outdated
@@ -34,3 +34,5 @@ debug | |||
resource.syso | |||
|
|||
*.resource.go | |||
|
|||
vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the building is happening in a temporary directory, do we need to ignore vendor dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, maybe its a good idea to do everything in tmp dir.
Done.
egonelbre
approved these changes
Oct 4, 2019
kaloyan-raev
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
Request Code Review
Code review requested
Reviewer Can Merge
If all checks have passed, non-owner can merge PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add building libuplink-android.aar to
Makefile
.Why: We need to automate libuplink-android and this change is part of larger task.
Please describe the tests:
Please describe the performance impact: none
Code Review Checklist (to be filled out by reviewer)