web/storagenode: chart y and x axis reworked #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliiShpital
added
Request Code Review
VitaliiShpital
requested review from
Barterio,
crawter,
NikolaiYurchenko and
a team
ghost
removed their request for review
Barterio
reviewed
Oct 4, 2019
| const middleDateValue = valuesLength / 2; | ||
| const isDateValueInMiddleInEvenAmount = index === (middleDateValue - 1); | ||
| const isDateValueInMiddleInNotEvenAmount = index === (Math.floor(middleDateValue)); | ||
| const isAfterEighthDayOfTheMonth = valuesLength > 8 && valuesLength <= 31; |
There was a problem hiding this comment.
This numbers should be moved to const with meaning description.
Avoid using magic numbers
Barterio
previously approved these changes
Oct 4, 2019
crawter
previously approved these changes
Oct 10, 2019
crawter
previously approved these changes
Oct 10, 2019
rikysya
previously approved these changes
Oct 11, 2019
crawter
reviewed
Oct 11, 2019
| @@ -7,6 +7,34 @@ import { Component, Prop, Vue, Watch } from 'vue-property-decorator'; | |||
|
|
|||
| import { ChartData } from '@/app/types/chartData'; | |||
|
|
|||
| class DayShowingConditions { | |||
| public day: string; | |||
crawter
reviewed
Oct 11, 2019
| @@ -7,6 +7,34 @@ import { Component, Prop, Vue, Watch } from 'vue-property-decorator'; | |||
|
|
|||
| import { ChartData } from '@/app/types/chartData'; | |||
|
|
|||
| class DayShowingConditions { | |||
| public day: string; | |||
| public daysArray: string[]; | |||
crawter
previously approved these changes
Oct 11, 2019
| class DayShowingConditions { | ||
| public day: string; | ||
| public daysArray: string[]; | ||
| public middleDateValue: number; |
| public day: string; | ||
| public daysArray: string[]; | ||
| public middleDateValue: number; | ||
| public isDateValueFirstOrLast: boolean; |
| public daysArray: string[]; | ||
| public middleDateValue: number; | ||
| public isDateValueFirstOrLast: boolean; | ||
| public isAfterEighthDayOfTheMonth: boolean; |
rikysya
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: number of x axis values reduced;
month added to x axis;
added y axis;
added label above y axis;
y axis dashed grid lines added.
Why: SNOboard enhancements
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)