Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storagenode/console: use bandwidth monthly summary #3183

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

rikysya
Copy link
Contributor

@rikysya rikysya commented Oct 4, 2019

What: Use bandwidth monthly summary for storagenode bandwidth usage instead of all time summary

Why: To be consistent with CLI dashboard

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@rikysya rikysya added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 4, 2019
@rikysya rikysya requested a review from a team October 4, 2019 14:20
@rikysya rikysya self-assigned this Oct 4, 2019
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2019
@ghost ghost requested review from JessicaGreben and simongui and removed request for a team October 4, 2019 14:20
@rikysya rikysya merged commit a11619e into master Oct 4, 2019
@rikysya rikysya deleted the yv/storagenode/console_bandwidth_monthly_summary branch October 4, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants