satellite/console: Added error for adding api key with existing name attempt. #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Barterio
added
Request Code Review
Barterio
added
Do Not Merge
and removed
Request Code Review
Barterio
added
Request Code Review
mniewrzal
previously approved these changes
Oct 9, 2019
satellite/console/service.go
Outdated
| @@ -779,6 +779,11 @@ func (s *Service) CreateAPIKey(ctx context.Context, projectID uuid.UUID, name st | |||
| return nil, nil, ErrUnauthorized.Wrap(err) | |||
| } | |||
|
|
|||
| _, err = s.store.APIKeys().GetByNameAndProjectID(ctx, name, projectID) | |||
| if err == nil { | |||
| return nil, nil, errs.New("An API Key with this name already exists in this project, please use a different name") | |||
There was a problem hiding this comment.
error message should start with lowercase
mniewrzal
previously approved these changes
Oct 9, 2019
crawter
reviewed
Oct 10, 2019
satellite/console/service.go
Outdated
| @@ -779,6 +779,11 @@ func (s *Service) CreateAPIKey(ctx context.Context, projectID uuid.UUID, name st | |||
| return nil, nil, ErrUnauthorized.Wrap(err) | |||
| } | |||
|
|
|||
| _, err = s.store.APIKeys().GetByNameAndProjectID(ctx, name, projectID) | |||
| if err == nil { | |||
| return nil, nil, errs.New("an API Key with this name already exists in this project, please use a different name") | |||
There was a problem hiding this comment.
place err message to constant
mniewrzal
previously approved these changes
Oct 10, 2019
mniewrzal
approved these changes
Oct 10, 2019
crawter
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added error for adding api key with existing name attempt
Why:
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)