Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/repair: defer close piecestore in downloadAndVerifyPiece #3192

Merged
merged 1 commit into from Oct 6, 2019

Conversation

cam-a
Copy link
Contributor

@cam-a cam-a commented Oct 6, 2019

What: add defer close piecestore in downloadAndVerifyPiece

Why: we are leaking connections and it is causing the satellite to crash

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cam-a cam-a requested a review from a team October 6, 2019 17:21
@cla-bot cla-bot bot added the cla-signed label Oct 6, 2019
@ghost ghost requested review from ethanadams and thepaul and removed request for a team October 6, 2019 17:21
Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cam-a cam-a merged commit eb5413a into master Oct 6, 2019
@cam-a cam-a deleted the ca/close_ps branch October 6, 2019 17:41
littleskunk pushed a commit that referenced this pull request Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants