Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/repair: remove deprecated error message #3193

Merged
merged 1 commit into from Oct 6, 2019
Merged

Conversation

littleskunk
Copy link
Member

What: Remove an old error message in repair checker.

Why: The audit job will remove bad pieces from pointer. As a result the repair checker will find pointers that contain only valid pieces but less than repair threshold. The repair checker will throw an error. I removed that error and executed the same test again. Now the repair checker will add the segment to the repair queue and the repair job will upload new pieces to new storage nodes. Everything works fine without that error validation.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@littleskunk littleskunk requested a review from a team October 6, 2019 18:43
@cla-bot cla-bot bot added the cla-signed label Oct 6, 2019
@ghost ghost requested review from Barterio and ifraixedes and removed request for a team October 6, 2019 18:43
@littleskunk littleskunk added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 6, 2019
@littleskunk littleskunk merged commit b908a09 into master Oct 6, 2019
@littleskunk littleskunk deleted the jh/repair branch October 6, 2019 18:54
littleskunk added a commit that referenced this pull request Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants