Installer: identity directory defaults to %APPDATA%\Storj\Identity\Storagenode

[Fadila82]

What: default value in the Identity Folder dialog of the Windows Installer points to %APPDATA%\Storj\Identity\Storagenode

Why: because it is the default location for identity tool to generate new storage node identity. Currently, the default is set to the root of the largest drive, which requires the user to always navigate to the location of their identity.

Acceptance criteria:

• The Identity Folder dialog displays %APPDATA%\Storj\Identity\Storagenode as the default value, where %APPDATA% is expanded to the actual location for the current user, e.g. C:\Users\IEUser\AppData\Roaming\Storj\Identity\Storagenode.

Please describe the tests: no test
Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

• Does the PR describe what changes are being made?
• Does the PR describe why the changes are being made?
• Does the code follow our style guide?
• Does the code follow our testing guide?
• Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
• Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
• Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
• Does any documentation need updating?
• Do the database access patterns make sense?

[kaloyan-raev]

I did more testing and I found that only this statement is enough to replace the above 5 lines:

<SetDirectory Action="SetIdentityDir" Id="IDENTITYDIR" Value="[AppDataFolder]Storj\Identity\Storagenode" Sequence="first">NOT Installed</SetDirectory>

Not that:

• The previous time I suggested this, I missed the Sequence="first" argument (that you correctly found that must be used). Without it, the IDENTITYDIR was reset to the default value when the Install button was clicked, although the user may have selected another value in the dialog.
• We don't need the \ after [AppDataFolder] as its value already ends with \.

[Fadila82]

The DirectorySearch lines are meant to make sure we open an existing directory. If the default identity files location does not exist, personal folder is used as a fallback. But maybe that's not what we want?

[kaloyan-raev]

Oh!!! This is so good. I had no idea we can actually do it. Forget what I am saying then :)

[kaloyan-raev]

nit: let's move this back to its original location - between the INSTALLFOLDER and STORAGEDIR properties.