Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/storj-sim: expose GATEWAY_X_API_KEY #3225

Merged
merged 4 commits into from
Oct 9, 2019
Merged

cmd/storj-sim: expose GATEWAY_X_API_KEY #3225

merged 4 commits into from
Oct 9, 2019

Conversation

wthorp
Copy link
Contributor

@wthorp wthorp commented Oct 9, 2019

What:
Expose GATEWAY_X_API_KEY in storj-sim network env

Why:
gateway setup or any similar use of libuplink has a setup phase which requires an API Key
there's already one created, it just wasn't easy to get at

Please describe the tests:

  • Test 1: none

Please describe the performance impact:
none

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@wthorp wthorp requested a review from a team October 9, 2019 17:21
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2019
@ghost ghost requested review from ethanadams and thepaul and removed request for a team October 9, 2019 17:21
@wthorp wthorp changed the title expose API_KEY cmd/storj-sim: expose GATEWAY_X_API_KEY env var Oct 9, 2019
@wthorp wthorp added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 9, 2019
@wthorp wthorp changed the title cmd/storj-sim: expose GATEWAY_X_API_KEY env var cmd/storj-sim: expose GATEWAY_X_API_KEY Oct 9, 2019
Copy link
Collaborator

@ethanadams ethanadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@mobyvb mobyvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works :)

@wthorp wthorp merged commit 9cbb0c4 into master Oct 9, 2019
@wthorp wthorp deleted the green/apikey branch October 9, 2019 18:33
isaachess pushed a commit that referenced this pull request Oct 10, 2019
littleskunk pushed a commit that referenced this pull request Oct 16, 2019
* expose API_KEY

(cherry picked from commit 9cbb0c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants