Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer/windows: custom welcome dialog #3228

Merged
merged 7 commits into from Oct 22, 2019

Conversation

Fadila82
Copy link
Contributor

@Fadila82 Fadila82 commented Oct 10, 2019

What: customize the windows installer welcome dialog with infos about prerequisites.

Why: The user should have infos about how to:like:

  • Received an auth token from STORJ
  • Generated an identity
  • Setup port forwarding

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@Fadila82 Fadila82 added the WIP Work In Progress label Oct 10, 2019
@Fadila82 Fadila82 requested a review from a team October 10, 2019 11:29
@cla-bot cla-bot bot added the cla-signed label Oct 10, 2019
@ghost ghost requested review from Barterio and ifraixedes and removed request for a team October 10, 2019 11:29
@Fadila82
Copy link
Contributor Author

image

@Fadila82 Fadila82 added Request Code Review Code review requested and removed WIP Work In Progress labels Oct 22, 2019
@kaloyan-raev kaloyan-raev changed the title Installer: custom welcome dialog installer/windows: custom welcome dialog Oct 22, 2019
@mniewrzal mniewrzal requested review from mniewrzal and removed request for Barterio October 22, 2019 13:21
@Fadila82 Fadila82 merged commit 9d84e63 into master Oct 22, 2019
@Fadila82 Fadila82 deleted the orange/installer-welcome-dialog branch October 22, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants