Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump drpc version #3235

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Bump drpc version #3235

merged 2 commits into from
Oct 10, 2019

Conversation

isaachess
Copy link
Contributor

What: Dump drpc version in go.mod.

Why: Fixes

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@isaachess isaachess requested a review from a team October 10, 2019 17:20
@cla-bot cla-bot bot added the cla-signed label Oct 10, 2019
@ghost ghost requested review from jenlij and JessicaGreben and removed request for a team October 10, 2019 17:20
@isaachess isaachess merged commit 89c6889 into master Oct 10, 2019
@isaachess isaachess deleted the ih/bumpdrpc branch October 10, 2019 19:48
littleskunk pushed a commit that referenced this pull request Oct 16, 2019
@isaachess @littleskunk
Bump drpc version (#3235)
bf74aa7 
(cherry picked from commit 89c6889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtolio jtolio jtolio approved these changes

@egonelbre egonelbre egonelbre approved these changes

@jenlij jenlij Awaiting requested review from jenlij

@JessicaGreben JessicaGreben Awaiting requested review from JessicaGreben

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaachess @jtolio @egonelbre