Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: add EncryptionRestrictions #3260

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

mniewrzal
Copy link
Contributor

What: Adds missing part of libuplink Sharing API.

Why: We need to expose this API in Java bindings.

Please describe the tests:

  • Test 1: simple automated test added

Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@mniewrzal mniewrzal added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 14, 2019
@mniewrzal mniewrzal requested a review from a team October 14, 2019 09:01
@ghost ghost requested review from Fadila82 and jenlij and removed request for a team October 14, 2019 09:01
@cla-bot cla-bot bot added the cla-signed label Oct 14, 2019
kaloyan-raev
kaloyan-raev previously approved these changes Oct 14, 2019
@mniewrzal mniewrzal merged commit 57ff0af into master Oct 15, 2019
@mniewrzal mniewrzal deleted the orange/mobile-encryptionrestrictions branch October 15, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants