Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/scope: small scope exploder command line tool #3266

Merged
merged 3 commits into from Oct 17, 2019

Conversation

jtolio
Copy link
Member

@jtolio jtolio commented Oct 14, 2019

what: this provides a small tool that breaks a scope into its constituent parts

Why: often someone wants to know what is in a scope!

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

this provides a small tool that breaks a scope into
its constituent parts

Change-Id: If011dd457a175eeb6e013a17d1aee4f3edfb8b0c
@jtolio jtolio added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 14, 2019
@jtolio jtolio requested a review from a team October 14, 2019 19:33
@cla-bot cla-bot bot added the cla-signed label Oct 14, 2019
@ghost ghost requested review from crawter and wthorp and removed request for a team October 14, 2019 19:33
@jtolio jtolio merged commit 863e4ca into master Oct 17, 2019
@jtolio jtolio deleted the jt/scope-exploder branch October 17, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants