-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
satellite/repair: improve logging #3287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as #3285
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least with comparison to #3285 i would prefer to have a more straight logging in terms when to log the path. Sometimes its logged in front, sometimes at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get it into the release, lets merge it as is and make a follow up PR @littleskunk
* satellite/repair: improve logging * use Stringer wherever possible (cherry picked from commit 6e76072)
What: Improve the logging around failed repair.
Why: At the moment the satellite prints out the encrypted path. It is hard to grep a logfile for the encrypted path. My hope is that with the new logging will allow us to grep, sort and count the binary value instead of the encrypted path. There is still one line that prints out the encrypted path so that we still have it if we need it.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)