gomobile Reader.Read should take offset and length params #3326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Reader.Read
in gomobile acceptsoffset
andlength
params.In addition, this PR fixes a bug in the usage of
length
inWriter.Write
method.Why: This allows more optimal usage from Java code. Java does not have slices like in Golang, but achieves the same on byte arrays with the usage of offset and length.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)