Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer/windows: add config dir flag to windows installer #3328

Merged
merged 3 commits into from Oct 21, 2019

Conversation

bryanchriswhite
Copy link
Contributor

What: Add --config-dir flag to the storagenode-updater service arguments.

Why: So the updater can correctly locate the storagenode config file.

Please describe the tests:
N/A

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@bryanchriswhite bryanchriswhite requested a review from a team October 21, 2019 13:57
@cla-bot cla-bot bot added the cla-signed label Oct 21, 2019
@ghost ghost requested review from Qweder93 and rikysya and removed request for a team October 21, 2019 13:57
@bryanchriswhite bryanchriswhite added the Request Code Review Code review requested label Oct 21, 2019
@bryanchriswhite bryanchriswhite added Reviewer Can Merge If all checks have passed, non-owner can merge PR Code Review In-Progress Code review in-progress Request Code Review Code review requested and removed Request Code Review Code review requested labels Oct 21, 2019
@mniewrzal mniewrzal merged commit 94cec7e into master Oct 21, 2019
@mniewrzal mniewrzal deleted the bryan/updater-quickfix branch October 21, 2019 18:22
@bryanchriswhite bryanchriswhite removed Code Review In-Progress Code review in-progress Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants