Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose range download in gomobile #3336

Merged
merged 2 commits into from Oct 22, 2019
Merged

Conversation

kaloyan-raev
Copy link
Member

@kaloyan-raev kaloyan-raev commented Oct 22, 2019

What: Exposes newRangeReader constructor in the gomobile code.

Why: We need to implement range downloads in the Java API

Please describe the tests:

  • Added test for newRangeReader
  • Some minor cleanup in existing tests

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@kaloyan-raev kaloyan-raev requested a review from a team October 22, 2019 05:36
@cla-bot cla-bot bot added the cla-signed label Oct 22, 2019
@ghost ghost requested review from JessicaGreben and thepaul and removed request for a team October 22, 2019 05:36
@kaloyan-raev kaloyan-raev added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 22, 2019
@kaloyan-raev kaloyan-raev merged commit 97018d6 into master Oct 22, 2019
@kaloyan-raev kaloyan-raev deleted the orange/gomobile-range-download branch October 22, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants