scripts: dev script to start postgres before tests #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniewrzal
added
Request Code Review
ghost
requested review from
crawter and
wthorp
and removed request for
a team
egonelbre
reviewed
Oct 23, 2019
ifraixedes
reviewed
Oct 23, 2019
ifraixedes
reviewed
Oct 23, 2019
egonelbre
previously approved these changes
Oct 24, 2019
thepaul
reviewed
Oct 24, 2019
thepaul
reviewed
Oct 24, 2019
scripts/test-sim-dev.sh
Outdated
| SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | ||
|
|
||
| CONTAINER_NAME=storj_sim_postgres | ||
| docker run -d --rm -p 5433:5432 --name $CONTAINER_NAME postgres:9.6 |
There was a problem hiding this comment.
It would be really nice to be able to collect logs from this postgres somewhere, either live or before the container is destroyed. maybe the best way would be to do docker logs $CONTAINER_NAME > $tmpfile in the cleanup function? or perhaps starting up something like tail -f $(docker inspect --format '{{.LogPath}}' $CONTAINER_NAME) > $tmpfile & here?
And then we could add -c log_min_duration_statement=0 to this invocation, and get nice logs about every query that goes through, for those times when we care.
There was a problem hiding this comment.
ok, I will try to combine it somehow :)
There was a problem hiding this comment.
live logging done
egonelbre
approved these changes
Oct 25, 2019
crawter
approved these changes
Oct 27, 2019
littleskunk
pushed a commit
that referenced
this pull request
Oct 28, 2019
(cherry picked from commit da2eaa7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Script for developers to run integration tests easier after removing storj-sim sqlite support. This script wraps main script and adds postgres (docker) server start, waits for the server to be available and starts integration tests.
Why: Now all developers need to have postgres configured or use docker image. This should our lives a little bit.
Please describe the tests:
Please describe the performance impact: none
Code Review Checklist (to be filled out by reviewer)