Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/satellite: temporarily removing payments api calls #3361

Merged
merged 1 commit into from
Oct 24, 2019
Merged

web/satellite: temporarily removing payments api calls #3361

merged 1 commit into from
Oct 24, 2019

Conversation

VitaliiShpital
Copy link
Member

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@VitaliiShpital VitaliiShpital added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Oct 24, 2019
@cla-bot cla-bot bot added the cla-signed label Oct 24, 2019
@ghost ghost removed their request for review October 24, 2019 14:02
@littleskunk littleskunk merged commit bff5c19 into storj:master Oct 24, 2019
littleskunk pushed a commit that referenced this pull request Oct 24, 2019
@VitaliiShpital VitaliiShpital deleted the web/satellite_removing_payment_api_calls branch October 24, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants