Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificates: move db test to separate file #3439

Merged
merged 3 commits into from Nov 4, 2019
Merged

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Nov 1, 2019

What:

  • Move DB related tests to db_test.go instead of authorizations_test.go
  • Rename MaxClockOffset to MaxClockSkew as per @egonelbre's suggestion

Why: Better organization.

Please describe the tests: N/A

Please describe the performance impact: N/A

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2019
@bryanchriswhite bryanchriswhite force-pushed the bryan/CA-test-reorg branch 2 times, most recently from ef98e5c to 8f3d9de Compare November 1, 2019 11:34
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 1, 2019 11:55
@bryanchriswhite bryanchriswhite requested a review from a team November 1, 2019 11:55
@bryanchriswhite bryanchriswhite added the Request Code Review Code review requested label Nov 1, 2019
@ghost ghost requested review from crawter and zeebo and removed request for a team November 1, 2019 11:55
mobyvb
mobyvb previously approved these changes Nov 1, 2019
crawter
crawter previously approved these changes Nov 1, 2019
@bryanchriswhite bryanchriswhite dismissed stale reviews from crawter and mobyvb via 11f9453 November 4, 2019 12:29
@bryanchriswhite bryanchriswhite changed the base branch from bryan/CA-time-window to master November 4, 2019 12:29
@bryanchriswhite bryanchriswhite added Code Review In-Progress Code review in-progress Reviewer Can Merge If all checks have passed, non-owner can merge PR and removed Do Not Merge Request Code Review Code review requested labels Nov 4, 2019
@mobyvb mobyvb merged commit f6a4155 into master Nov 4, 2019
@bryanchriswhite bryanchriswhite deleted the bryan/CA-test-reorg branch November 12, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Code Review In-Progress Code review in-progress Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants