Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer/windows: batch file improvements #3441

Merged
merged 16 commits into from Jan 3, 2020

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Nov 1, 2019

What: Batch file improvements for windows installer build and installation automation (extracted from #3338).

Why: In preparation for V3-3044.

Please describe the tests: N/A

Please describe the performance impact: N/A

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2019
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 1, 2019 11:32
@bryanchriswhite bryanchriswhite requested a review from a team November 1, 2019 11:32
@ghost ghost requested review from kaloyan-raev and navillasa and removed request for a team November 1, 2019 11:32
@bryanchriswhite bryanchriswhite added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Nov 1, 2019
installer/windows/build.bat Show resolved Hide resolved
installer/windows/build.bat Outdated Show resolved Hide resolved
installer/windows/installrelease.bat Show resolved Hide resolved
installer/windows/install.bat Outdated Show resolved Hide resolved
mniewrzal
mniewrzal previously approved these changes Nov 12, 2019
Copy link
Contributor

@mniewrzal mniewrzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

mniewrzal
mniewrzal previously approved these changes Nov 13, 2019
mniewrzal
mniewrzal previously approved these changes Nov 18, 2019
@bryanchriswhite
Copy link
Contributor Author

bryanchriswhite commented Dec 3, 2019

@kaloyan-raev here's a build on the private jenkins of this branch plus a commit to prevent error messages from hitting slack in the event that it failed:
https://build.storj.io/blue/organizations/jenkins/Storj%20V3/detail/windows-ci/35/pipeline/

Here's the last commit in that branch: 53dc30f, you can see its parent is 1fb1967.

@egonelbre
Copy link
Member

Note, waiting a review from @kaloyan-raev

Copy link
Member

@kaloyan-raev kaloyan-raev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested on the private Jenkins: https://build.storj.io/job/Storj%20V3/job/test3441/1/

@kaloyan-raev kaloyan-raev merged commit 3257907 into master Jan 3, 2020
@kaloyan-raev kaloyan-raev deleted the bryan/installer-automation branch January 3, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants