New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer/windows: batch file improvements #3441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
83d312f
to
58e6d98
Compare
@kaloyan-raev here's a build on the private jenkins of this branch plus a commit to prevent error messages from hitting slack in the event that it failed: Here's the last commit in that branch: 53dc30f, you can see its parent is 1fb1967. |
Note, waiting a review from @kaloyan-raev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested on the private Jenkins: https://build.storj.io/job/Storj%20V3/job/test3441/1/
What: Batch file improvements for windows installer build and installation automation (extracted from #3338).
Why: In preparation for V3-3044.
Please describe the tests: N/A
Please describe the performance impact: N/A
Code Review Checklist (to be filled out by reviewer)