Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/payments/tokens: return checkout url on new deposit #3696

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

rikysya
Copy link
Contributor

@rikysya rikysya commented Dec 5, 2019

What: return checkout url on new deposit

Why: so we can redirect a customer to checkout page immediately

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@rikysya rikysya added the Request Code Review Code review requested label Dec 5, 2019
@rikysya rikysya requested a review from a team December 5, 2019 14:13
@rikysya rikysya self-assigned this Dec 5, 2019
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2019
@ghost ghost requested review from JessicaGreben and kaloyan-raev and removed request for a team December 5, 2019 14:13
@rikysya rikysya merged commit f659d98 into master Dec 12, 2019
@rikysya rikysya deleted the yv/satellite/payments/token-deposit_return_link branch December 12, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants