web/satellite: billing page behaviour #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ifraixedes and
zeebo
and removed request for
a team
NikolaiYurchenko
requested review from
crawter,
VitaliiShpital and
a team
and removed request for
a team
Qweder93
previously approved these changes
Dec 9, 2019
web/satellite/src/components/account/billing/paymentMethods/TokenDepositSelection.vue
Outdated
Show resolved
Hide resolved
| @@ -96,6 +96,10 @@ export default class MonthlyBillingSummary extends Vue { | |||
| * toggleUsageChargesPopup is used to open/close area with list of project charges. | |||
| */ | |||
| public toggleUsageChargesPopup(): void { | |||
| if (this.usageCharges.length === 0) { | |||
There was a problem hiding this comment.
if (!this.usageCharges.length)?
There was a problem hiding this comment.
IMO straight comparison is more readable in this case
VitaliiShpital
approved these changes
Dec 12, 2019
rikysya
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Custom amount, balance and usage charges changes
Why:
Ability to select custom amount as default, black color positive balance and disability to expand usage charges if no any
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)