Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/metainfo: remove RS validation for bucket creation #3791

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

mniewrzal
Copy link
Contributor

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@mniewrzal mniewrzal requested a review from a team March 2, 2020 15:31
@cla-bot cla-bot bot added the cla-signed label Mar 2, 2020
@ghost ghost requested review from ifraixedes and rikysya and removed request for a team March 2, 2020 15:31
@egonelbre egonelbre requested review from littleskunk and removed request for ifraixedes and rikysya March 2, 2020 15:40
@littleskunk littleskunk merged commit 5ecc53a into release-alpha34 Mar 3, 2020
@littleskunk littleskunk deleted the remove-rs-validation branch March 3, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants