Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/satellite: Enable admin service like other services, also sort environment variables #3874

Merged
merged 2 commits into from
May 8, 2020

Conversation

brimstone
Copy link
Contributor

@brimstone brimstone commented May 7, 2020

What: Enable admin service like other services

Why: Consistency is key.

Please describe the tests: n/a

Please describe the performance impact: 100% on admin service

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

…vironment variables

Change-Id: I67592b7bf34a0e2ce9a445b58b7fa34396aa8c5d
@brimstone brimstone requested a review from a team May 7, 2020 18:18
@cla-bot cla-bot bot added the cla-signed label May 7, 2020
@ghost ghost requested review from mobyvb and zeebo and removed request for a team May 7, 2020 18:18
@brimstone brimstone added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels May 7, 2020
@brimstone brimstone merged commit 94503db into master May 8, 2020
@brimstone brimstone deleted the mr/enable-admin branch May 8, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants