Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/satellite: ensure we only create stripe customers for activated users #3884

Merged
merged 1 commit into from
May 15, 2020
Merged

cmd/satellite: ensure we only create stripe customers for activated users #3884

merged 1 commit into from
May 15, 2020

Conversation

stefanbenten
Copy link
Contributor

@stefanbenten stefanbenten commented May 15, 2020 •
edited by mniewrzal

What: changes the SQL query to not generate stripe customers for users that are not activated.

Why: It currently does the opposite

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@stefanbenten
cmd/satellite: ensure we only create stripe customers for activated u…
d1169ff 
…sers

Change-Id: I506e060d9bda10fff17ee7fd9f60bf331cccc1fe
@stefanbenten stefanbenten added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels May 15, 2020
@cla-bot cla-bot bot added the cla-signed label May 15, 2020
@ghost ghost removed their request for review May 15, 2020 13:31
@stefanbenten stefanbenten merged commit 26f36d5 into master May 15, 2020
@stefanbenten stefanbenten deleted the sb/ensure-customers branch May 15, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iglesiasbrandon iglesiasbrandon iglesiasbrandon approved these changes

@mniewrzal mniewrzal mniewrzal approved these changes

@kaloyan-raev kaloyan-raev Awaiting requested review from kaloyan-raev

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanbenten @iglesiasbrandon @mniewrzal