Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satellite/admin: add user creation endpoint #3889

Merged
merged 4 commits into from
May 18, 2020
Merged

satellite/admin: add user creation endpoint #3889

merged 4 commits into from
May 18, 2020

Conversation

stefanbenten
Copy link
Contributor

@stefanbenten stefanbenten commented May 18, 2020 •
edited

What: adds user creation endpoint

Why: It allows mass creation of users

Please describe the tests:

  • Test 1: added test for creation

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@stefanbenten
satellite/admin: add user creation endpoint
40fba26 
Change-Id: Ie07d5be6b570c4ff3f16d041e40d40e242411968
@stefanbenten
json fixes
4135c73 
Change-Id: I4452f061c2d8038af14eef2c14fe189cbb4d00ee
@stefanbenten stefanbenten added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels May 18, 2020
@cla-bot cla-bot bot added the cla-signed label May 18, 2020
@ghost ghost removed their request for review May 18, 2020 18:33
@stefanbenten
Copy link
Contributor Author

further unblocking of #3887

VinozzZ
VinozzZ suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't find where the close is called automatically

@stefanbenten stefanbenten merged commit 17d3cb1 into master May 18, 2020
@stefanbenten stefanbenten deleted the sb/admin-user-split branch May 18, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonelbre egonelbre egonelbre approved these changes

@VinozzZ VinozzZ VinozzZ approved these changes

@kaloyan-raev kaloyan-raev Awaiting requested review from kaloyan-raev

@littleskunk littleskunk Awaiting requested review from littleskunk

@mniewrzal mniewrzal Awaiting requested review from mniewrzal

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanbenten @egonelbre @VinozzZ