Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Go 1.14.7 #3926

Merged
merged 2 commits into from
Aug 12, 2020
Merged

build: Go 1.14.7 #3926

merged 2 commits into from
Aug 12, 2020

Conversation

brimstone
Copy link
Contributor

@brimstone brimstone commented Aug 11, 2020 •
edited by stefanbenten

What: Update to latest Go

Why: Updates are good

Please describe the performance impact: Non expected or tested.

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

build: Go 1.14.7
1fec11d 
Change-Id: I84217679a1a770bbec2bb254cd575f2ee61f3530
@brimstone brimstone requested a review from a team August 11, 2020 14:59
@cla-bot cla-bot bot added the cla-signed label Aug 11, 2020
@ghost ghost requested review from mobyvb and zeebo and removed request for a team August 11, 2020 14:59
@ifraixedes ifraixedes merged commit c548475 into master Aug 12, 2020
@ifraixedes ifraixedes deleted the mr/go-1.14.7 branch August 12, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonelbre egonelbre egonelbre approved these changes

@stefanbenten stefanbenten stefanbenten approved these changes

@mobyvb mobyvb Awaiting requested review from mobyvb

@zeebo zeebo Awaiting requested review from zeebo

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brimstone @egonelbre @stefanbenten @ifraixedes