Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/accounting: Add index for project_id on bucket_storage_tallies #4010

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

ethanadams
Copy link
Collaborator

@ethanadams ethanadams commented Dec 21, 2020

Change-Id: I47ab2d1e24f94307c3383c497cffe2a150fa8ab7

What:
Add index for project_id on bucket_storage_tallies

Why:
Improve performance of like SELECT DISTINCT bucket_name FROM bucket_storage_tallies WHERE project_id = $1

Please describe the tests:

  • Test 1: Existing tests
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Change-Id: I47ab2d1e24f94307c3383c497cffe2a150fa8ab7
@cla-bot cla-bot bot added the cla-signed label Dec 21, 2020
@ghost ghost removed their request for review December 21, 2020 15:55
@ethanadams ethanadams merged commit 9b52283 into master Dec 21, 2020
@ethanadams ethanadams deleted the bucket_storage_tallies_index_project_id branch December 21, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants